🪲 Prevent checkpoint when the scene has not changed #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisFederico
approved these changes
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
The fix is not very beautiful (it computes the hash of the scene to check if it was changed), but straightforward solutions don't work with the current setup (for example, just checking that the history of the pyeditor hasn't changed doesn't cut it, because if you modify the block, then move around, then focus out, the pyeditor will consider that the last change did change the block).
The solution I propose has the benefit of being robust against any "double checkpoint" that one might introduce in the future.
Furthermore, it doesn't cost more than the previous state of the program, since it was already serializing the whole scene every time.