-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kernel #17
Merged
Merged
Feature/kernel #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenCodeBlocks into feature/IPythonExecution
🔧 Refactor execute_function 📝 Refactor execute_function docstring
…ocks into feature/kernel
…a. This makes it easier to locate the resizing area when using the interface.
…f a block independently. During this process, some duplicated code for setting the size of said panel is removed.
This was
linked to
issues
Nov 13, 2021
Closed
…ssues. Did not run to yet to avoid merge conflicts.
…se moves quickly from the resizing area to outside of it. Also, tied the start of the resizing to the cursor appearance to help with consistency between cursor appearance and if the area is resizable if changes are made.
Refactor execute and update_output using new method get_message
message was overriden on last iteration when execution_state is idle.
This was
unlinked from
issues
Nov 17, 2021
Closed
Closed
MathisFederico
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this for now, even if there is a few issues left on the matter !
@AlexandreSajus go and create a new branch for each specific issue you aim to solve !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.