Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Fix bug related to ipynb conversion #129

Merged
merged 4 commits into from
Jan 4, 2022
Merged

🪲 Fix bug related to ipynb conversion #129

merged 4 commits into from
Jan 4, 2022

Conversation

FabienRoger
Copy link
Contributor

No description provided.

@FabienRoger FabienRoger linked an issue Jan 4, 2022 that may be closed by this pull request
Ipynb conversion does not work #128
Closed
MathisFederico
MathisFederico reviewed Jan 4, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick question about edges loading:

opencodeblocks/graphics/edge.py Show resolved Hide resolved
MathisFederico
MathisFederico approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice bug-fix !
It would be nice to add a test to ensure this behave correctly in the future as well

@MathisFederico
Copy link
Member

MathisFederico commented Jan 4, 2022 •
edited
Loading

Also, in the future, add markers like this:
Fixes #128

So that issue is linked and automatically closed when the PR is merged

@MathisFederico MathisFederico merged commit 5dc13de into master Jan 4, 2022
@MathisFederico MathisFederico deleted the bug/fix_ipynb_conversion branch January 5, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisFederico MathisFederico MathisFederico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ipynb conversion does not work
2 participants
@FabienRoger @MathisFederico