Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☔ Add unit tests to ipynb conversion #117

Merged
merged 6 commits into from
Dec 19, 2021

Conversation

FabienRoger
Copy link
Contributor

@FabienRoger FabienRoger commented Dec 14, 2021

Add tests for ipynb conversion

@FabienRoger
Copy link
Contributor Author

I think the test I added cause an out-of-memory error. I don't know how to fix it.

@FabienRoger FabienRoger changed the title features/ipynbconversion ☔ Add unit tests to ipynb conversion Dec 14, 2021
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to merge that ! Tests are always welcome !

tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
tests/unit/scene/test_ipynb_conversion.py Outdated Show resolved Hide resolved
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !
Thank you a lot !
Tests are always very welcome !

@MathisFederico MathisFederico merged commit 3f28dec into master Dec 19, 2021
@MathisFederico MathisFederico deleted the Add-ipynb-conversion-draft branch December 19, 2021 12:27
@MathisFederico MathisFederico restored the Add-ipynb-conversion-draft branch December 19, 2021 12:27
@MathisFederico MathisFederico deleted the Add-ipynb-conversion-draft branch December 19, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants