-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️Execution Refactor & 🎉 Nested Nodes #113
Conversation
…uted. This will be used to make sliders "executable".
e3ae908
to
ee02258
Compare
You can for example plot matplotlib graph and see changes in live !
✨ Remove unused imports
…pened, they do not share the same kernel
256c948
to
e9c2615
Compare
7bbaa50
to
17fef8a
Compare
By creating a new kernel when creating a new scene, file loading and file creation is a bit slower. So in case somebody in the future wants to increase file opening performance, he should focus on this. |
e1e92c7
to
b1762ce
Compare
A lot has been done. Nodes can be grouped but nodes inside containers cannot interact with the outside. They don't even share the same kernel ! (And I'd argue this is a good thing as containers might run on different python versions) |
…e of the developer that might have been better spent implementing useful features or resolving bugs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some things that we will need to change:
-
Allow to change slider min, max and step, and base scale (linear vs exp?)
-
Make nested blocks easier to use.
-
Make output panels always open when raising error, color block when ran / failed.
But those will be for other PRs.
From what has been announced, this PR still lacks of multiple tests.
Working on adding the tests right now ! |
Note that @abstractproperty should not be used here: https://docs.python.org/3.8/library/abc.html#abc.abstractproperty
…or a block to complete instead of just waiting 3 seconds.
657e785
to
b849327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you, I've not had time to review everything as there is too much changes in this PR
…lly added by git during a merge.
54283f9
to
41b7f17
Compare
…manager. These are not integration tests ! There is no QApplication setup that allows you to retrieve theme information.
41b7f17
to
2817584
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. run_left and run_right will be modified further in feature/visual-flow
Don't delete the branch ! Nested blocks need to be improved |
A lot of new blocks have been added but they are not executable yet !
This pull request aims to:
While this might seem like multiple features added at once, because they are all deeply intertwined, it makes sense to group them in the same branch.
More specifically, we will try to fix: