Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 When selecting an OCBBlock, it is brought to the front. #11

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

vanyle
Copy link
Contributor

@vanyle vanyle commented Oct 27, 2021

It's a small cosmetic change but it's something nice to have.

It's a small cosmetic change but it's something nice to have.
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a better way to bring the block on top without modifying others blocks ZValues ?

opencodeblocks/graphics/view.py Outdated Show resolved Hide resolved
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"action" is unused in this method

opencodeblocks/graphics/view.py Outdated Show resolved Hide resolved
@vanyle vanyle force-pushed the feature/selected_in_front branch from 638964a to 9016152 Compare October 27, 2021 22:11
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !
Thanks a lot !

@MathisFederico MathisFederico merged commit 3b7d48f into master Oct 27, 2021
@MathisFederico MathisFederico deleted the feature/selected_in_front branch October 27, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants