Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some links #39

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Update some links #39

merged 2 commits into from
Jan 30, 2021

Conversation

atouchet
Copy link
Contributor

Changes:

  • Update links to use HTTPS when available
  • Link to updated versions of doc pages
  • Fix broken crates.io link
  • Remove dead AppVeyor badge

BurntSushi
BurntSushi requested changes Jan 24, 2021
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM with a couple small changes.

wincolor/README.md Outdated
crate since `wincolor` is quite small and didn't otherwise have a good reason
for living life as a distinct crate.

The
[`console`](https://docs.rs/winapi-util/0.1.3/x86_64-pc-windows-msvc/winapi_util/console/index.html)
[`console`](https://docs.rs/winapi-util/*/x86_64-pc-windows-msvc/winapi_util/console/index.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use 0.1.*.

README.md Outdated
@@ -85,7 +85,7 @@ fn write_green() -> io::Result<()> {
### Automatic color selection

When building a writer with termcolor, the caller must provide a
[`ColorChoice`](https://docs.rs/termcolor/1.0.5/termcolor/enum.ColorChoice.html)
[`ColorChoice`](https://docs.rs/termcolor/*/termcolor/enum.ColorChoice.html)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.*.

BurntSushi
BurntSushi approved these changes Jan 30, 2021
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 020816f into BurntSushi:master Jan 30, 2021
@atouchet atouchet deleted the links branch January 31, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atouchet @BurntSushi