Implement WriteColor for std::io::Sink #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you like me to add a test? |
BurntSushi
requested changes
Jan 30, 2021
src/lib.rs
Outdated
| @@ -1450,6 +1450,20 @@ impl<W: io::Write> Ansi<W> { | |||
| } | |||
| } | |||
|
|
|||
| impl WriteColor for io::Sink { | |||
| fn supports_color(&self) -> bool { | |||
| true | |||
There was a problem hiding this comment.
I think this should probably be false? Why did you return true here?
There was a problem hiding this comment.
I was unsure if there is ever a situation where you absolutely need a sink which supports color. I can change it to false.
There was a problem hiding this comment.
What would a sink that supports color look like? It never writes anything so it would seem to me that it can't support color?
There was a problem hiding this comment.
Hmm, sorry I might have mistaken what support_color meant. I thought support_color meant you can write colored output to the sink without encountering any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #37 by implementing
WriteColorforstd::io::Sink. ASinkis a writer which moves data into the void, and can be useful for when you want to measure the performance of a program without including I/O.