sys: disable jit on apple aarch64 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Aug 26, 2020
clang fails with
Undefined symbols for architecture arm64:
"___clear_cache", referenced from:
_sljit_generate_code in libforeign.a(pcre2_jit_compile.o)
ld: symbol(s) not found for architecture arm64
BurntSushi
approved these changes
Aug 27, 2020
| // x86_64-apple-ios-macabi disabled out of caution (not tested) (needs attention) | ||
| // | ||
| // We may want to monitor developments on the `aarch64-apple-darwin` front as they may end up | ||
| // propagating to all `aarch64`-based targets and the `x86_64` equivalents. |
BurntSushi
added a commit
to BurntSushi/ripgrep
that referenced
this pull request
Aug 27, 2020
This brings in a PR that disables the JIT on certain Apple targets since it doesn't appear to build. See: BurntSushi/rust-pcre2#16
|
This PR is on crates.io in Thanks again! |
|
the following patch might help, but it is likely incomplete as the resulting code is known to cause older versions of iOS to crash (unless the iDevice was rooted), you might be interested on testing zherczeg/sljit#90 if the objective is to have JIT enabled in Apple Silicon eventually |
|
@carenas Thanks. Yes, it would be nice to have the JIT enabled on Apple silicon eventually. But not only do I not have access to Apple's new silicon, but I won't have the bandwidth to do that kind of testing anyway. Thank you for the heads up though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang fails with
I’ve only tested an
aarch64-apple-iosbuild, but see here and here for the others.I also disabled it on the equivalent x86_64 targets to keep an identical binary across simulators and Catalyst (
x86_64-apple-ios-macabi); the latter might be debatable assuming the symbols are there as they should be, and we might want to enable it there.