Better (shorter, clearer) debug implementation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
pushed a commit
that referenced
this pull request
Oct 18, 2020
Previously, any non-printable Unicode scalar value would get printed
using the '\u{...}' syntax. While not horrible, it's a bit weird to
do this for ASCII characters and especially for the NUL and various
whitespace characters. So this commit tweaks the Debug impl for BStr to
handle those cases specially in a way that's a bit more consistent with
what folks expect.
Fixes #56, Closes #58
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2022
Bump the ripgrep commit exercised by cargotest This update goes from BurntSushi/ripgrep@3de31f7 (Aug 1, 2019) to current master, BurntSushi/ripgrep@ced5b92 (March 21, 2022). I need this in order to pick up BurntSushi/ripgrep#1722, which picked up BurntSushi/bstr#58, which unblocks rust-lang#95345. Ripgrep uses the Debug representation of a `BStr` in some of its tests. In old versions of bstr, that used to just use the standard library's `escape_debug()` implementation, so the output ends up being sensitive to whether the standard library renders character 0 as `\u{0}` or as `\0`. The newer bstr always renders character 0 as `\0` and ripgrep's test suite has been correspondingly updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Note: apart from what is discussed here I've also included
\0escape. In Rust this is not an octal escape but a special case similar to\nand\t. Given that it's quite often used in binary data, and is shorter this way, I think it justifies the special case.