-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular output has TS code in a JS file #499
Comments
fixes BuilderIO#473 fixes BuilderIO#476 fixes BuilderIO#499
Should be ts |
@PatrickJS my PR in progress makes it so |
Yeah we use core directly so I think there's a slight disconnect with some changes and the CLI |
When you use core directly, are you taking responsibility yourself for file naming etc.? I have not dug into the code in core versus CLI, but hopefully there is not different, conflicting output file naming code between them :-) :-( |
Yeah core just outputs a string so this is more of an issue with the CLI. Mitosis should definitely output ts as the default or at least for angular. We need a way to detect what output we want (ts or js) |
fixes BuilderIO#473 fixes BuilderIO#476 fixes BuilderIO#499
To Reproduce
look at
packages/e2e-app/output/angular/src/components/my-component.js
Expected behavior
Either emit JS Angular (which is rarely used), or name the file
.ts
.The text was updated successfully, but these errors were encountered: