Convert builder components helpers to ts #15564
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| return searchComponentTree(rootComponent, comp => comp._component === type) | ||
| } | ||
|
|
||
| /** | ||
| * Recursively searches for the parent component of a specific component ID | ||
| */ | ||
| export const findComponentParent = (rootComponent, id, parentComponent) => { | ||
| export const findComponentParent = ( | ||
| rootComponent: Component | undefined, |
There was a problem hiding this comment.
Could these all be set as optional?
There was a problem hiding this comment.
rootComponent and id shouldn't be optional (or even allowed to be undefined) but it's just because the code that calls this probably isn't all TS - so we can't guarantee that we're not passing in something undefined by mistake. The 3rd param is optional, since it's intended to be blank when called externally, but it's used when it invokes itself via recursion.
There was a problem hiding this comment.
As @aptkingston mentioned this is reflecting the current usages... Most of them should not be nullable, but until everything is fully typed will not be safe to refactor
| export const findComponentPath = (rootComponent, id, path = []) => { | ||
| export const findComponentPath = ( | ||
| rootComponent: Component, | ||
| id: string | undefined, |
There was a problem hiding this comment.
Same here, an optional string for the id param instead of string | undefined
| componentId, | ||
| selector | ||
| rootComponent: Component, | ||
| componentId: string | undefined, |
There was a problem hiding this comment.
Possible optional value
| @@ -1,3 +1,5 @@ | |||
| // TODO: analise and fix all the undefined ! and ? | |||
There was a problem hiding this comment.
🥚 Just checking if this was intentionally left in
There was a problem hiding this comment.
Yes, this was left intentionally as it will require a much bigger refactor
Description
Convert builder components helpers to ts