Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert client builder store #15543

Merged
merged 12 commits into from
Feb 14, 2025
Merged

Convert client builder store #15543

merged 12 commits into from
Feb 14, 2025

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Feb 13, 2025

Description

Convert client builder store

Copy link

qa-wolf bot commented Feb 13, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@adrinr adrinr requested review from mike12345567, aptkingston and deanhannigan and removed request for mike12345567 February 13, 2025 11:09
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few type suggestions to make this stricter 👌

hiddenComponentIds: []
usedPlugins: { name: string; hash: string }[] | null
eventResolvers: {}
metadata: { componentId: string; step: number } | null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any usages of this metadata... maybe we can remove it too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in MultiStepFormblock.svelte

Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran through it locally and didn't run into any issues

@adrinr adrinr requested a review from a team as a code owner February 14, 2025 12:04
@adrinr adrinr requested a review from aptkingston February 14, 2025 12:14
@adrinr adrinr merged commit 511d320 into master Feb 14, 2025
20 checks passed
@adrinr adrinr deleted the convert-client-builder-store branch February 14, 2025 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants