Cleaning up loop.spec.ts, moved tests from automation.spec.ts to more appropriate places. #15536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appropriate places.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
commented
Feb 12, 2025
Comment on lines
+123
to
+147
| it("should be able to clean inputs with the utilities", () => { | ||
| // can't clean without a schema | ||
| let output = cleanInputValues({ a: "1" }) | ||
| expect(output.a).toBe("1") | ||
| output = cleanInputValues( | ||
| { a: "1", b: "true", c: "false", d: 1, e: "help" }, | ||
| { | ||
| properties: { | ||
| a: { | ||
| type: "number", | ||
| }, | ||
| b: { | ||
| type: "boolean", | ||
| }, | ||
| c: { | ||
| type: "boolean", | ||
| }, | ||
| }, | ||
| } | ||
| ) | ||
| expect(output.a).toBe(1) | ||
| expect(output.b).toBe(true) | ||
| expect(output.c).toBe(false) | ||
| expect(output.d).toBe(1) | ||
| }) |
There was a problem hiding this comment.
This has been moved from automation.spec.ts to here.
samwho
commented
Feb 12, 2025
Comment on lines
+34
to
+72
| const result = await createAutomationBuilder(config) | ||
| .onAppAction() | ||
| .queryRows({ | ||
| tableId: table._id!, | ||
| }) | ||
| .loop({ | ||
| option: LoopStepType.ARRAY, | ||
| binding: "{{ steps.1.rows }}", | ||
| }) | ||
| .serverLog({ text: "log statement" }) | ||
| .test({ fields: {} }) | ||
|
|
||
| expect(result.steps[1].outputs.iterations).toBe(1) | ||
| }) | ||
|
|
||
| it("test a loop with a string", async () => { | ||
| const resp = await runLoop({ | ||
| option: LoopStepType.STRING, | ||
| binding: "a,b,c", | ||
| }) | ||
| expect(resp.steps[2].outputs.iterations).toBe(3) | ||
| const result = await createAutomationBuilder(config) | ||
| .onAppAction() | ||
| .loop({ | ||
| option: LoopStepType.STRING, | ||
| binding: "a,b,c", | ||
| }) | ||
| .serverLog({ text: "log statement" }) | ||
| .test({ fields: {} }) | ||
|
|
||
| expect(result.steps[0].outputs.iterations).toBe(3) | ||
| }) | ||
|
|
||
| it("test a loop with a binding that returns an integer", async () => { | ||
| const resp = await runLoop({ | ||
| option: LoopStepType.ARRAY, | ||
| binding: "{{ 1 }}", | ||
| }) | ||
| expect(resp.steps[2].outputs.iterations).toBe(1) | ||
| const result = await createAutomationBuilder(config) | ||
| .onAppAction() | ||
| .loop({ | ||
| option: LoopStepType.ARRAY, | ||
| binding: "{{ 1 }}", | ||
| }) | ||
| .serverLog({ text: "log statement" }) | ||
| .test({ fields: {} }) | ||
|
|
||
| expect(result.steps[0].outputs.iterations).toBe(1) |
There was a problem hiding this comment.
These should be identical to their runLoop counterparts, but using the new builder instead of runLoop.
samwho
commented
Feb 12, 2025
Comment on lines
+46
to
+73
| it("should correct coerce values based on the schema", async () => { | ||
| const { automation } = await createAutomationBuilder(config) | ||
| .onAppAction({ | ||
| fields: { text: "string", number: "number", boolean: "boolean" }, | ||
| }) | ||
| .serverLog({ | ||
| text: "{{ fields.text }} {{ fields.number }} {{ fields.boolean }}", | ||
| }) | ||
| .save() | ||
|
|
||
| await config.api.application.publish() | ||
|
|
||
| const jobs = await captureAutomationResults(automation, async () => { | ||
| await config.withProdApp(async () => { | ||
| await config.api.automation.trigger(automation._id!, { | ||
| fields: { text: "1", number: "2", boolean: "true" }, | ||
| timeout: 1000, | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| expect(jobs).toHaveLength(1) | ||
| expect(jobs[0].data.event.fields).toEqual({ | ||
| text: "1", | ||
| number: 2, | ||
| boolean: true, | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This is new to cover a test that was happening in automation.spec.ts
mike12345567
approved these changes
Feb 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loop.spec.tshad some tests that weren't usingcreateAutomationBuilderso I converted them.automation.spec.tswas doing some mocking that we don't need anymore now that we havecreateAutomationBuilder, so I wrote a new test inappAction.spec.tsthat covered what it was doing, moved another test from it intoautomationUtils.spec.ts, and deleted the file.