Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App action tests #15535

Merged
merged 3 commits into from
Feb 12, 2025
Merged

App action tests #15535

merged 3 commits into from
Feb 12, 2025

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Feb 12, 2025

Create tests for the app action trigger type for automations.

@samwho samwho requested a review from a team as a code owner February 12, 2025 12:20
@samwho samwho requested review from mike12345567 and removed request for a team February 12, 2025 12:20
Copy link

qa-wolf bot commented Feb 12, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added size/s firestorm Data/Infra/Revenue Team labels Feb 12, 2025
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptive LGTM - but think it would be nice to differentiate between the addition of a trigger and triggering the automation.

@samwho samwho merged commit e80db7b into master Feb 12, 2025
20 checks passed
@samwho samwho deleted the app-action-tests branch February 12, 2025 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants