New component drag-and-drop improvements #15497
Conversation
…d typing improvements for client
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
… into grid-new-component-dnd
There was a problem hiding this comment.
LGTM! Love it. A really intuitive UX enhancement and some really nice updates to the core DnD behaviour! 🎉
Gave this a rinse locally and didn't run into any issues!
NOTE - Small default size for the following. Have to resize to see the help UX. Not a blocker at all.
- Dynamic filter
- Date range
- Icon
| @@ -1,7 +1,7 @@ | |||
| import { Readable, Writable } from "svelte/store" | |||
|
|
|||
| declare module "./memo" { | |||
| export function memo<T>(value: T): Writable<T> | |||
| export function memo<T>(value?: T): Writable<T> | |||
Cheers Dean. Nice one finding those components that look weird by default too, due to error states. I think I'll update the icon to just pick an icon by default to solve that one. For the others it's not so easy, since they need a data provider. And when there is a data provider, they are much smaller than the error state. I'll add some logic to attempt to auto fill in data provider type settings, which will help reduce the frequency of initial error states. |
Description
This PR updates and refactors a lot of the drag and drop code, particularly when adding components. The primary new feature is the ability to drag components directly on to grid screens, in the position of your choice.
Here's an example of adding a few new components to a grid screen:
Screen.Recording.2025-02-12.at.15.02.27.mov
Dragging components on to flex screens is unaffected.
Other stuff
@/xxxapproach (same as builder)