Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNUInstallDirs variables for CMake install destinations #76

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

hesiod
Copy link
Contributor

@hesiod hesiod commented Mar 14, 2023

This PR replaces bare relative install destinations like bin or lib with their corresponding variables from GNUInstallDirs (see module documentation). The variables should default to the same values as previously used (other than CMAKE_INSTALL_DOCDIR, for which we override the default). For example, CMAKE_INSTALL_BINDIR defaults to bin.

Using variables from GNUInstallDirs can simplify packaging Geogram in some cases as it allows overriding install destinations for certain file types. Using GNUInstallDirs variables is commonly considered a good practice (at least to my knowledge).

There are no standard variables for CMake and pkg-config files. Therefore this PR adds GEOGRAM_INSTALL_CMAKE_DIR and GEOGRAM_INSTALL_PKGCONFIG_DIR.

@hesiod hesiod mentioned this pull request Mar 14, 2023
12 tasks
@BrunoLevy BrunoLevy merged commit 7a793f8 into BrunoLevy:main Mar 15, 2023
@hesiod hesiod deleted the cmake-include-paths branch March 16, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants