Fix segmentation fault in nlEigenSolve_ARPACK #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 18, 2024 13:26
…d number of eigenvectors to the NL context
|
Thank you very much ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid segmentation fault caused by ARPack incrementing the requested number of eigenvalues in nlEigenSolve_ARPACK. This workaround avoids the invalid access by enforcing that at most the requested number of eigenvalues are copied to the NL context.
See this issue where the manifold_harmonics sample program crashes due to a segmentation fault with certain values of nb_eigens on Windows.