-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make geogram initialization less intrusive. #64
Comments
There are other very annoying behavior with the A much better approach would be to default-initialize simple parameter structs in various headers, and only tie that to actual cmd line args in Geogram's applications. I'm a big fan of CLI11's API for doing this (e.g. see this example in Lagrange). |
|
Ideally, a library shouldn't use any global at all. I'd prefer to have to manually create a Regarding the |
Add init flags and make init less intrusive by default (fixes #64)
Currently geogram requires a call to GEO::initialize(), which is very intrusive:
LC_NUMERIC
on Unix systematexit()
function.Ideally such an initialization function should not be needed for a library integrated in a larger system. My recommendation:
atexit()
function.GEO::initialize()
altogether (e.g. have each system call their own singleton struct as needed, or rework systems to remove the need for globals altogether).The text was updated successfully, but these errors were encountered: