Skip to content

Commit

Permalink
- MeshHalfedges: function for taking region into account was confusing,
Browse files Browse the repository at this point in the history
with an implicit conversion to bool. Created another overload to
disambiguate.
- Preparing Release 1.8.4
  • Loading branch information
BrunoLevy committed Jun 26, 2023
1 parent 67a846a commit ddacc70
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.0)
cmake_policy(SET CMP0048 NEW)

##############################################################################
set(VORPALINE_VERSION_RC TRUE)
set(VORPALINE_VERSION_RC FALSE)
set(VORPALINE_VERSION_MAJOR 1)
set(VORPALINE_VERSION_MINOR 8)
set(VORPALINE_VERSION_PATCH 4)
Expand Down
11 changes: 11 additions & 0 deletions src/lib/geogram/mesh/mesh_halfedges.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,17 @@ namespace GEO {
facet_region_.bind(mesh_.facets.attributes(),attribute_name);
}

/**
* \brief Sets a facet attribute name that determines borders.
* \param[in] attribute_name the name of the facet attribute to
* be used to determine borders.
* \details Needed to have this overload, because const char*
* is implicitly converted to bool instead of std::string.
*/
void set_use_facet_region(const char* attribute_name) {
set_use_facet_region(std::string(attribute_name));
}


/**
* \brief Tests whether a Halfedge is valid.
Expand Down

0 comments on commit ddacc70

Please sign in to comment.