fix: build macos with xcode llvm #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896
Read my comments in the issue for more step by step details on what was happening.
The TLDR is that this library current uses the symbol
__ZTTNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEEwhich was introduced in macos 12, even though compiling was telling it to target 10.13.After quite some digging and debugging to figure out why, I have concluded that its the different config of brew llvm compared to system llvm, causing llvm to ignore the requested target.
This resolves that by simply using the system llvm instead.
I am not certain that the changes in build-skia.js are needed, but they match the setup done for
aarch64-apple-darwinI have verified this on an old mac I have which is running 10.13, after rerunning the skia compile step, and producing the new
skia.darwin-x64.nodefrom that it is now loadable on 10.13