fix: bitmap destructor

Brooooooklyn · Jan 18, 2021 · b138da2 · b138da2
1 parent 8d5ded6
commit b138da2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/skia-c/skia_c.cpp b/skia-c/skia_c.cpp
@@ -763,4 +763,9 @@ extern "C"
     auto bitmap = reinterpret_cast<SkBitmap *>(c_bitmap);
     return bitmap->height();
   }
+
+  void skiac_bitmap_destroy(skiac_bitmap *c_bitmap)
+  {
+    delete BITMAP_CAST;
+  }
 }
diff --git a/skia-c/skia_c.hpp b/skia-c/skia_c.hpp
@@ -223,6 +223,7 @@ extern "C"
   skiac_bitmap *skiac_bitmap_make_from_buffer(uint8_t *ptr, size_t size);
   uint32_t skiac_bitmap_get_width(skiac_bitmap *c_bitmap);
   uint32_t skiac_bitmap_get_height(skiac_bitmap *c_bitmap);
+  void skiac_bitmap_destroy(skiac_bitmap *c_bitmap);
 }
 
 #endif // SKIA_CAPI_H
diff --git a/src/sk.rs b/src/sk.rs
@@ -423,6 +423,8 @@ mod ffi {
     pub fn skiac_bitmap_get_width(c_bitmap: *mut skiac_bitmap) -> u32;
 
     pub fn skiac_bitmap_get_height(c_bitmap: *mut skiac_bitmap) -> u32;
+
+    pub fn skiac_bitmap_destroy(c_bitmap: *mut skiac_bitmap);
   }
 }
 
@@ -2083,6 +2085,14 @@ impl Bitmap {
   }
 }
 
+impl Drop for Bitmap {
+  fn drop(&mut self) {
+    unsafe {
+      ffi::skiac_bitmap_destroy(self.bitmap);
+    }
+  }
+}
+
 #[inline(always)]
 fn radians_to_degrees(rad: f32) -> f32 {
   (rad / PI) * 180.0