fix: Windows icudtl.data version and path

Brooooooklyn · Aug 5, 2021 · 5c81eb7 · 5c81eb7
1 parent f4f2499
commit 5c81eb7
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 50 deletions.
diff --git a/.github/workflows/CI.yaml b/.github/workflows/CI.yaml
@@ -542,6 +542,9 @@ jobs:
       - name: Move artifacts
         run: pnpm artifacts
 
+      - name: Download ICU for Windows
+        run: node ./scripts/release-skia-binary.js --download-icu
+
       - name: List packages
         run: ls -R ./npm
         shell: bash

diff --git a/npm/icudtl/README.md b/npm/icudtl/README.md
diff --git a/npm/icudtl/package.json b/npm/icudtl/package.json
diff --git a/npm/icudtl/postinstall.js b/npm/icudtl/postinstall.js
diff --git a/npm/win32-x64-msvc/package.json b/npm/win32-x64-msvc/package.json
@@ -4,7 +4,7 @@
   "os": ["win32"],
   "cpu": ["x64"],
   "main": "skia.win32-x64-msvc.node",
-  "files": ["skia.win32-x64-msvc.node"],
+  "files": ["skia.win32-x64-msvc.node", "icudtl.dat"],
   "description": "Canvas for Node.js with skia backend",
   "keywords": [
     "napi-rs",

diff --git a/scripts/release-skia-binary.js b/scripts/release-skia-binary.js
@@ -108,7 +108,7 @@ async function download() {
   }
   if (PLATFORM_NAME === 'win32') {
     await downloadIcu()
-    await fs.copyFile(join(__dirname, '..', ICU_DAT), join(__dirname, '..', 'npm', 'icudtl', ICU_DAT))
+    await fs.copyFile(join(__dirname, '..', ICU_DAT), join(__dirname, '..', 'npm', 'win32-x64-msvc', ICU_DAT))
   }
 }