Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not guess file types #273

Open
diekhans opened this issue Aug 16, 2023 · 2 comments
Open

Please do not guess file types #273

diekhans opened this issue Aug 16, 2023 · 2 comments
Labels
Documentation Update ReadTheDocs manual enhancement New feature or request mod; correct

Comments

@diekhans
Copy link
Collaborator

diekhans commented Aug 16, 2023

ssCorrect.py attempt to guess if a BED or STAR junction file was passed in can silently fail and produce incorrect results.

Please do not try to be easy to use by "guessing" and silently ignore, have explicit command line arguments for STAR vs BED.

This "save time" feature waste da lot of hours. Be rigorous.

@diekhans
Copy link
Collaborator Author

Have two options one for shortreads from BED and the other from STAR junction files will also help guide people that they should not be using junctions_from_bam with STAR BAMs.

By default, STAR doesn't output the XS tag. It is there for cuff links compatibility. It also has some side effects that someone running STAR might not want (discards reads with non-canonical). Probably, the doc should say, "you really should use STAR junctions file if you use STAR"

@diekhans
Copy link
Collaborator Author

this overlaps #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update ReadTheDocs manual enhancement New feature or request mod; correct
Projects
None yet
Development

No branches or pull requests

2 participants