Feature/exclude classes protocols #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TadeasKriz and this one as well ;) |
MatyasKriz
reviewed
Mar 28, 2017
| @@ -68,6 +70,19 @@ public struct GenerateMocksCommand: CommandProtocol { | |||
| return FileRepresentation(sourceFile: $0.sourceFile, declarations: declarations) | |||
| }.filter { !$0.declarations.isEmpty } | |||
| } | |||
|
|
|||
| private func removeClassedAndProtocols(from files: [FileRepresentation], in excluded: [String]) -> [FileRepresentation] { | |||
There was a problem hiding this comment.
Typo: removeClassedAndProtocols
There was a problem hiding this comment.
Cheers @sparkesix for your sharp eye
nxtstep
force-pushed
the
feature/exclude-classes-protocols
branch
from
739cb97 to
81a37c0
Compare
|
Hi, sorry for the long delay. I finally merged huge change and I'd like to ask you if you could try and rebase this PR on top of current master. Then I'd like to merge it. Thanks! |
nxtstep
force-pushed
the
feature/exclude-classes-protocols
branch
from
81a37c0 to
8d09211
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional feature to exclude certain classes and protocols from being mocked.
Use case:
So we do need the protocol to be defined as input files for inheritance. But we exclude the protocol as being mock 'stand-alone'.