Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback Policy Decorator not registered after upgrade to 2.0.63 #78

Closed
ajaffie opened this issue Sep 3, 2019 · 3 comments
Closed

Fallback Policy Decorator not registered after upgrade to 2.0.63 #78

ajaffie opened this issue Sep 3, 2019 · 3 comments
Assignees
Labels

Comments

@ajaffie
Copy link

ajaffie commented Sep 3, 2019

After upgrading to 2.0.63, the FallbackPolicyDecorator does not seem to be registered automatically. We now need to register it manually by adding it via assembly and explicitly registering the decorator type in Startup.cs, like this:

// ...
services.AddDarker()
    .AddHandlersFromAssemblies(typeof(Paramore.Darker.Decorators.FallbackPolicyDecorator<,>).Assembly)
    .RegisterDecorator(typeof(Paramore.Darker.Decorators.FallbackPolicyDecorator<,>))
// ...

It looks like the changes were mentioned here in issue #65.
Is this going to be necessary going forward or is it a bug that will be fixed?
Thanks.

@holytshirt holytshirt self-assigned this Sep 3, 2019
@holytshirt holytshirt added the bug label Sep 3, 2019
@holytshirt
Copy link
Member

@ajaffie Sorry about that, that is a bug. I'll get it fixed. Thank you for report it!

@holytshirt
Copy link
Member

@colinangusmackay Does this affect you too?

@holytshirt
Copy link
Member

I've fixed this and pushed to Nuget. Version 2.0.78 has the fix.

Thank you for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants