Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtabs white textcolor on white background #103

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Fix subtabs white textcolor on white background #103

merged 2 commits into from
Jul 2, 2023

Conversation

Ultimatum22
Copy link
Contributor

I noticed the sub tabs for Sprint (shootout & results) & Race (qualifyings & results) looked empty. A better way it to solve this globally instead of per tabview, but this works for now.

Keep up the good work, I'll try to contribute some more PRs if you appreciate it.

@BrightDV BrightDV merged commit 1936af3 into BrightDV:main Jul 2, 2023
@BrightDV
Copy link
Owner

BrightDV commented Jul 2, 2023

Nice catch! I don't test that much the app is light mode…
Anyway, thanks for the PR, and you are very welcome if you want to do more PRs :)
Also, if you do some others, add some screenshots and it would be perfect!

@Ultimatum22
Copy link
Contributor Author

Screenshots of the issue before you mean? You like before and after screenshots or screenshots of the issue is fine?

No worries, I am using the app regular so I like to contribute back. I've already some minor issues. If you like me to add new features let me know.

@BrightDV
Copy link
Owner

BrightDV commented Jul 2, 2023

I prefer one before and one after, to see what is the issue and how it is resolved.
You can add new features if you think that they are useful! However, before you start working on it, open an issue with the idea, so you can explain the purpose and how you would implement it.
For the bugfixes like this one, just doing a PR is fine 👍

@Ultimatum22 Ultimatum22 deleted the fix-subtabs-white-textcolor-on-white-background branch July 4, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants