Skip to content

Commit

Permalink
Merge pull request #22 from BrickworkSoftware/add-chunkhash-back
Browse files Browse the repository at this point in the history
Put chunkhash in build paths
  • Loading branch information
morgs32 authored Jan 22, 2018
2 parents 8d8c647 + d46042a commit 055c1ff
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/react-scripts/config/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ module.exports = {
// Process JS with Babel.
{
test: /\.(js|jsx)$/,
exclude: /node_modules(?!\/@brickwork-software\/asiago)/,
exclude: /node_modules(?!\/@brickwork-software\/asiago|dot-prop)/,
include: [
paths.appPath,
paths.asiagoPath,
Expand Down
8 changes: 4 additions & 4 deletions packages/react-scripts/config/webpack.config.prod.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if (env.stringified['process.env'].NODE_ENV !== '"production"') {
}

// Note: defined here because it will be used more than once.
const cssFilename = 'static/css/[name].[contenthash:8].css';
const cssFilename = '[contenthash:8]/static/css/[name].css';

// ExtractTextPlugin expects the build output to be flat.
// (See https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/27)
Expand Down Expand Up @@ -91,8 +91,8 @@ module.exports = {
// Generated JS file names (with nested folders).
// There will be one main bundle, and one file per asynchronous chunk.
// We don't currently advertise code splitting but Webpack supports it.
filename: 'static/js/[name].js',
chunkFilename: 'static/js/[name].chunk.js',
filename: '[chunkhash:8]/static/js/[name].js',
chunkFilename: '[chunkhash:8]/static/js/[name].chunk.js',
jsonpFunction: 'brickworkJsonpFunction',
// We inferred the "public path" (such as / or /my-project) from homepage.
publicPath: publicPath,
Expand Down Expand Up @@ -201,7 +201,7 @@ module.exports = {
// Process JS with Babel.
{
test: /\.(js|jsx)$/,
exclude: /node_modules(?!\/@brickwork-software\/asiago)/,
exclude: /node_modules(?!\/@brickwork-software\/asiago|dot-prop)/,
include: [
paths.appPath,
paths.asiagoPath,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@brickwork-software/react-scripts",
"version": "1.3.1",
"version": "1.3.3",
"description": "Configuration and scripts for Brickwork react apps",
"repository": "brickworksoftware/create-react-app",
"license": "BSD-3-Clause",
Expand Down

0 comments on commit 055c1ff

Please sign in to comment.