Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resolution property #683

Merged
merged 8 commits into from
Feb 4, 2025
Merged

add resolution property #683

merged 8 commits into from
Feb 4, 2025

Conversation

metesaka
Copy link
Contributor

This commit targets to solve #682

@metesaka metesaka closed this Feb 2, 2025
@metesaka metesaka reopened this Feb 2, 2025
@gtfierro
Copy link
Member

gtfierro commented Feb 3, 2025

Can you rewrite the condition on the "comment artifact" step to be if: ${{ github.event_name == 'pull_request' && matrix.python-version == env.RELEASE_PYTHON_VERSION && github.event.pull_request.head.repo.full_name == 'BrickSchema/Brick' }}? This should sidestep the permissions issue

@metesaka
Copy link
Contributor Author

metesaka commented Feb 3, 2025

It skipped comment artifact with the new config.

@gtfierro gtfierro merged commit 804ee49 into BrickSchema:master Feb 4, 2025
4 checks passed
@gtfierro gtfierro linked an issue Feb 4, 2025 that may be closed by this pull request
Adding resolution as an Entity Property #682
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtfierro gtfierro gtfierro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding resolution as an Entity Property
2 participants
@metesaka @gtfierro