Add target and threshold setpoints #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjcantrell
commented
May 30, 2024
| @@ -27,10 +34,16 @@ | |||
| "Enthalpy_Setpoint": { | |||
There was a problem hiding this comment.
@gtfierro Is Enthalpy_Setpoint intended to be used as an enthalpy to be maintained (target), or an enthalpy to enable something such as an economizer (lower/upper threshold)?
There was a problem hiding this comment.
I think I have mostly seen it as a target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on Option 1 of issue #608.
In addition to existing class hierarchies, setpoints are now a subclass of either Target Setpoint or Upper/Lower Threshold Setpoint.