Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Srr qudt 2 1 37 #631

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Srr qudt 2 1 37 #631

merged 10 commits into from
Apr 15, 2024

Conversation

steveraysteveray
Copy link
Collaborator

@gtfierro, here is what the QUDT imports graph should look like after the changes I suggested in email are done on your end.

image

@gtfierro gtfierro marked this pull request as ready for review April 15, 2024 03:25
@gtfierro gtfierro merged commit c685f5b into master Apr 15, 2024
2 checks passed
@steveraysteveray
Copy link
Collaborator Author

Interestingly, this implementation surfaced a couple of minor errors in the QUDT schema, which have already been fixed for the next QUDT release. I'm still puzzling why they weren't flagged in other environments. The error messages are generated by tosh via the brick->rec->dash->tosh import, but even explicitly importing tosh into either the 223 workspace or the QUDT native workspace doesn't surface the errors (even though they are valid errors that needed correcting).

image

Regardless, I'm grateful that the validation in Brick is finding them!

@steveraysteveray steveraysteveray deleted the srr-qudt-2-1-37 branch April 16, 2024 18:28
@gtfierro
Copy link
Member

Interesting! It seems like there are so many paths for ontologies to be included and for rules to be run that it can be hard to get reproducible results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants