Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when printing the brewday. #318

Merged
merged 1 commit into from
Sep 17, 2016
Merged

Fix a crash when printing the brewday. #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/BrewDayScrollWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,30 @@ QString BrewDayScrollWidget::getCSS()
return css;
}

static QString styleName(Style* style)
{
if ( ! style )
{
return "unknown";
}
else
{
return style->name();
}
}

static QString boilTime(Equipment* equipment)
{
if ( ! equipment )
{
return "unknown";
}
else
{
return Brewtarget::displayAmount(equipment->boilTime_min(), "tab_recipe", "boilTime_min", Units::minutes);
}
}

QString BrewDayScrollWidget::buildTitleTable(bool includeImage)
{
QString header;
Expand All @@ -337,7 +361,7 @@ QString BrewDayScrollWidget::buildTitleTable(bool includeImage)
body += QString("<tr><td class=\"left\">%1</td>")
.arg(tr("Style"));
body += QString("<td class=\"value\">%1</td>")
.arg(recObs->style()->name());
.arg(styleName(recObs->style()));
body += QString("<td class=\"right\">%1</td>")
.arg(tr("Date"));
body += QString("<td class=\"value\">%1</td></tr>")
Expand All @@ -346,7 +370,7 @@ QString BrewDayScrollWidget::buildTitleTable(bool includeImage)
// second row: boil time and efficiency.
body += QString("<tr><td class=\"left\">%1</td><td class=\"value\">%2</td><td class=\"right\">%3</td><td class=\"value\">%4</td></tr>")
.arg(tr("Boil Time"))
.arg(Brewtarget::displayAmount(recObs->equipment()->boilTime_min(), "tab_recipe", "boilTime_min", Units::minutes))
.arg(boilTime(recObs->equipment()))
.arg(tr("Efficiency"))
.arg(Brewtarget::displayAmount(recObs->efficiency_pct(),0,0));

Expand Down