Closes feature request #25 -- multiple dialogs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes feature request Brewtarget#25 -- multiple dialogs when canceling a copy. I rearranged things so that the code in MainWindow is much cleaner; there are no more copyThis() methods. Instead I drove all the complexity into BtTreeView and BtTreeModel, like deleteSelected. This does somewhat change the syntax of the cancel button. To avoid copying a single item, just enter an empty name. I added a tool type to explain this. I also changed the "Cancel" button to read "Cancel All", hoping this will make it more obvious.
|
👍 |
rocketman768
added a commit
that referenced
this pull request
May 7, 2015
Closes #25 -- multiple dialogs when canceling a copy
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes feature request #25 -- multiple dialogs when canceling a copy. I
rearranged things so that the code in MainWindow is much cleaner; there are no
more copyThis() methods. Instead I drove all the complexity into BtTreeView
and BtTreeModel, like deleteSelected.
This does somewhat change the syntax of the cancel button. To avoid copying a
single item, just enter an empty name. I added a tool type to explain this. I
also changed the "Cancel" button to read "Cancel All", hoping this will make
it more obvious.