Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you change the scale of the Boil Time in the equipment dialog the prg cash #137

Closed
ddk1965 opened this issue Jan 11, 2016 · 3 comments
Labels

Comments

@ddk1965
Copy link

ddk1965 commented Jan 11, 2016

Only solution is to put a previous copy of your .config/brewtarget back ...

@rocketman768
Copy link
Member

Confirmed

@rocketman768
Copy link
Member

This is bad, very bad. Need to fix this immediately in stable/2.3.0.

Program received signal SIGSEGV, Segmentation fault.
0x0000000000678da3 in UnitSystem::displayAmount (this=0x0, amount=60, units=0x9ed230, precision=3, scale=Unit::scaleSmall)
    at /home/philip/myc/brewtarget/brewtarget/src/UnitSystem.cpp:99
99         if( units == 0 || units->getUnitType() != _type)
(gdb) bt
#0  0x0000000000678da3 in UnitSystem::displayAmount (this=0x0, amount=60, units=0x9ed230, precision=3, scale=Unit::scaleSmall)
at /home/philip/myc/brewtarget/brewtarget/src/UnitSystem.cpp:99
#1  0x0000000000500517 in Brewtarget::displayAmount (amount=60, units=0x9ed230, precision=3, displayUnits=1, displayScale=Unit::scaleSmall)
at /home/philip/myc/brewtarget/brewtarget/src/brewtarget.cpp:1142
#2  0x00000000004f7159 in BtLineEdit::displayAmount (this=0x10a4df0, amount=60, precision=3) at /home/philip/myc/brewtarget/brewtarget/src/BtLineEdit.cpp:248
#3  0x00000000004f7a86 in BtLineEdit::setText (this=0x10a4df0, element=0xc6a8f0, precision=3) at /home/philip/myc/brewtarget/brewtarget/src/BtLineEdit.cpp:303
#4  0x00000000005a0570 in EquipmentEditor::showChanges (this=0x10989b0) at /home/philip/myc/brewtarget/brewtarget/src/EquipmentEditor.cpp:701
#5  0x000000000059ed34 in EquipmentEditor::setEquipment (this=0x10989b0, e=0xc6a8f0) at /home/philip/myc/brewtarget/brewtarget/src/EquipmentEditor.cpp:524
#6  0x000000000059f4c5 in EquipmentEditor::equipmentSelected (this=0x10989b0) at /home/philip/myc/brewtarget/brewtarget/src/EquipmentEditor.cpp:572
#7  0x0000000000598126 in EquipmentEditor::EquipmentEditor (this=0x10989b0, parent=0xe2cd80, singleEquipEditor=false)
at /home/philip/myc/brewtarget/brewtarget/src/EquipmentEditor.cpp:107
#8  0x00000000005c7e63 in MainWindow::MainWindow (this=0xe2cd80, parent=0x0) at /home/philip/myc/brewtarget/brewtarget/src/MainWindow.cpp:160
#9  0x00000000004fb1ce in Brewtarget::run () at /home/philip/myc/brewtarget/brewtarget/src/brewtarget.cpp:578
#10 0x00000000004b8af9 in main (argc=1, argv=0x7fffffffe0f8) at /home/philip/myc/brewtarget/brewtarget/src/main.cpp:53

rocketman768 added a commit that referenced this issue Jan 13, 2016
Fixes the segfault
@rocketman768
Copy link
Member

Fixed the segfault, but the real problem is something going awry in BtLabel.

this failed BtVolumeLabel(0x10d4e30, name = "label_evaporationRate")
this failed BtTimeLabel(0x10cc390, name = "label_boilTime")
WARNING: BtLineEdit::toSI : could not convert 60.000 min to double
this failed BtTimeLabel(0x10cc390, name = "label_boilTime")
this failed BtTimeLabel(0x10cc390, name = "label_boilTime")
WARNING: BtLineEdit::toSI : could not convert 0.000 min to double
this failed BtTimeLabel(0x10cc390, name = "label_boilTime")
WARNING: BtLineEdit::toSI : could not convert 0.000 min to double

$ git grep 'this failed'
src/BtLabel.cpp:      qDebug() << "this failed" << this;

@mikfire any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants