Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import distance functions from powersimdata #92

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jun 25, 2020

Purpose

Functions calculating angular distance between two locations and initially located in the PreREISE package have been moved in the PowerSimData package because those were needed to add generators to a Grid object.

What is the code doing?

There is no code. Some functions have been deleted and some some import statements have been modified.

Where to look

The import statements.

Time estimate

5 min

Tests

All tests pass:

================================================================ test session starts =================================================================
platform darwin -- Python 3.6.5, pytest-4.5.0, py-1.8.0, pluggy-0.13.0
rootdir: /Users/brdo/REM/PreREISE
collected 38 items                                                                                                                                   

prereise/gather/demanddata/eia/tests/test_clean_data.py .                                                                                      [  2%]
prereise/gather/demanddata/eia/tests/test_get_eia_data.py s.                                                                                   [  7%]
prereise/gather/demanddata/eia/tests/test_map_ba.py ....                                                                                       [ 18%]
prereise/gather/solardata/tests/test_pv_tracking.py ..........                                                                                 [ 44%]
prereise/gather/tests/test_get_monthly_net_generation.py .                                                                                     [ 47%]
prereise/gather/winddata/rap/tests/test_power_curves.py ...................                                                                    [ 97%]
prereise/gather/winddata/te_wind/tests/test_te_wind.py .                                                                                       [100%]

================================================= 37 passed, 1 skipped, 9 warnings in 117.39 seconds =================================================

@rouille rouille added this to the Black Lives Matter milestone Jun 25, 2020
@rouille rouille requested review from BainanXia and jenhagg June 25, 2020 04:08
Copy link
Collaborator

@jenhagg jenhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rouille rouille merged commit 2a85822 into develop Jun 25, 2020
@rouille rouille deleted the import_distance_functions_from_powersimdata branch June 25, 2020 19:22
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants