Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve solar profile #44

Merged
merged 9 commits into from
Dec 11, 2019
Merged

Improve solar profile #44

merged 9 commits into from
Dec 11, 2019

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Dec 3, 2019

Solar profiles have been improved as follows:

  • DC capacity are now used as system size in the System Adviser Model (SAM). A DC to AC ratio of 1.25 is used for all plants. This is where the median and capacity wighted average sits according to the this EIA article.
  • The capacity weighted average of the array type (fix, single-axis and dual-axis) ratios has been calculated for each zones. A unique set of ratios for each interconnect was used in the previous version.

More information is available on ZenHub (Issue #43)

@rouille rouille added new feature Feature that is currently in progress. data collection Input data (demand, hydro/solar/wind) labels Dec 3, 2019
@rouille rouille added this to the Sprint 1 milestone Dec 3, 2019
danielolsen
danielolsen reviewed Dec 3, 2019
View reviewed changes
prereise/gather/solardata/pv_tracking.py Outdated
:return: (*pandas.DataFrame*) -- solar pv plant information as found in
form EIA860
"""
file = os.path.dirname(__file__) + '/data/3_3_Solar_Y2016.xlsx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like os.path.join would be useful here to ensure cross-platform compatibility.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Done.

danielolsen
danielolsen reviewed Dec 3, 2019
View reviewed changes
prereise/gather/solardata/pv_tracking.py Outdated
"""
file = os.path.dirname(__file__) + '/data/3_3_Solar_Y2016.xlsx'

solar_plant_info = pd.read_excel(io=file, header=0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving the data file as .csv rather than .xlsx would make it easier to keep track of any changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

kasparm
kasparm reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init.py missing in the tests folder.

danielolsen
danielolsen reviewed Dec 3, 2019
View reviewed changes
prereise/gather/solardata/tests/mock_pv_info.py
Comment on lines +12 to +14
single = ['N', 'Y', 'Y', 'Y', 'Y']
dual = ['Y', 'N', 'N', 'N', 'Y']
fix = ['N', 'Y', 'Y', 'N', 'N']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there only be five Y values, if we're matching Form 860? The same plant can't be fixed and single-axis tracking.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some entries in form 860 where the same plant has both fix tilt and single axis tracking. Some farms use dual and single and other dual and fix. Few farms use all 3 technologies.

My understanding was that within one farm,, panels can operate in a different way.

@kasparm
Copy link
Contributor

kasparm commented Dec 3, 2019

In cell 5 in https://github.com/intvenlab/PreREISE/blob/improve_solar_profile/prereise/gather/solardata/nsrdb/demo/nsrdb_sam_demo.ipynb
You have an hard coded address, could you remove it and explain?
Also, make sure to point setup.py to the data, otherwise it will not be copied when installed with pip install.
I did not test the code that requires the api-key.
Otherwise, good job.

@rouille
Copy link
Collaborator Author

rouille commented Dec 4, 2019

@kasparm. I cannot remove the link. This is where the System Adviser Model (SAM) external library is locater. The user needs to install it on its own computer and it is OS dependent. That is why it is hardcoded.

@kasparm
Copy link
Contributor

kasparm commented Dec 5, 2019

What I meant is to please remove the link and put in a placeholder. Something like
... and shortly what it means, such that somebody else can use it.

danielolsen
danielolsen approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we may want to look at the loading ratios by state (rather than 1.25 everywhere) and we may want to be able to look at different years of data (rather than the hardcoded 2016), but this looks great for now.

@rouille
Copy link
Collaborator Author

rouille commented Dec 11, 2019

NREL recently developed (in 2019) a Python wrapper for SAM (PySAM). It is available through pip and hence avoid the use of external library. I believe we should start using it and refactor PreREISE/prereise/gather/solardata/nsrdb/sam.py.

@rouille rouille force-pushed the improve_solar_profile branch from e0f82c8 to 5d4df2d Compare December 11, 2019 22:56
@rouille rouille merged commit ac1c31c into develop Dec 11, 2019
@rouille rouille deleted the improve_solar_profile branch December 11, 2019 22:58
@ahurli ahurli mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparm kasparm kasparm left review comments

@danielolsen danielolsen danielolsen approved these changes

@BainanXia BainanXia Awaiting requested review from BainanXia

Assignees

@kasparm kasparm

@rouille rouille

Labels
data collection Input data (demand, hydro/solar/wind) new feature Feature that is currently in progress.
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.
4 participants
@rouille @kasparm @danielolsen @BainanXia