Use scenario object to call engine #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into callForScenarioObject
kasparm
reviewed
Jul 12, 2019
| @@ -30,24 +32,25 @@ def ll2ij(lon_origin, lat_origin, lon, lat): | |||
|
|
|||
|
|
|||
| def to_reise(data): | |||
There was a problem hiding this comment.
@rouille Do you remember if this formatting is still necessary with the scenario object?
There was a problem hiding this comment.
Yes it is. We still need to create base profile for the scenario object. And I need to reformat the information I query from NREL and NOAA to a data frame with UTC timestamp as index and plant id as columns.
… package is installed
kasparm
force-pushed
the
callForScenarioObject
branch
from
2760bc5 to
e7f6289
Compare
kasparm
approved these changes
Jul 18, 2019
Merged
jmbott
pushed a commit
to SEL-Columbia/PreREISE
that referenced
this pull request
May 26, 2022
* add 2019 fuel data * style: restructure area_scale_res * chore: add 2018 column to area_scale_com * feat: update model fitting to all for any input base_year with necessary fitting data * feat: update puma_fuel * chore: move frac_target_sh_res.csv location * fix: scaling from gbs areas corrected * fix: update blob storage temp referencing * chore: minor comment cleanup * refactor: clean up code through testing * chore: code style cleanup * fix: correct blob reference for puma_temps * fix: correct temp_ref_it defining * fix: uncomment data_dir definition within functions * fix: strike commented redundant data column * fix: area scaling syntax cleanup * style: basic cleanup * style: linting fix Co-authored-by: Daniel Olsen <[email protected]>
BainanXia
pushed a commit
to SEL-Columbia/PreREISE
that referenced
this pull request
Feb 21, 2023
* add 2019 fuel data * style: restructure area_scale_res * chore: add 2018 column to area_scale_com * feat: update model fitting to all for any input base_year with necessary fitting data * feat: update puma_fuel * chore: move frac_target_sh_res.csv location * fix: scaling from gbs areas corrected * fix: update blob storage temp referencing * chore: minor comment cleanup * refactor: clean up code through testing * chore: code style cleanup * fix: correct blob reference for puma_temps * fix: correct temp_ref_it defining * fix: uncomment data_dir definition within functions * fix: strike commented redundant data column * fix: area scaling syntax cleanup * style: basic cleanup * style: linting fix Co-authored-by: Daniel Olsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that have been done: