Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder structure an ATTRIBUTION file #191

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Folder structure an ATTRIBUTION file #191

merged 2 commits into from
Jul 13, 2021

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jul 12, 2021

Pull Request doc

Purpose

Create folder structure and update ATTRIBUTION.md. HIFLD files have been uploaded to the BES blob storage.

What the code is doing

N/A

Testing

N/A

Where to look

  • Formatted a previous entry
  • 3 new entries for HIFLD data (transmission, substation and generation)

Usage Example/Visuals

N/A

Time estimate

10min

@rouille rouille added the data intake Use of external data label Jul 12, 2021
@rouille rouille self-assigned this Jul 12, 2021
danielolsen
danielolsen reviewed Jul 12, 2021
View reviewed changes
BainanXia
BainanXia reviewed Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume other file changes are due to a rebase onto the latest develop.

@rouille
Copy link
Collaborator Author

rouille commented Jul 12, 2021

I presume other file changes are due to a rebase onto the latest develop.

Yeah, I rebased hifld onto the lates develop but forgot to force push

BainanXia
BainanXia approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ahurli
ahurli approved these changes Jul 12, 2021
View reviewed changes
Copy link

@ahurli ahurli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rouille rouille merged commit f829416 into hifld Jul 13, 2021
@rouille rouille deleted the ben/data branch July 13, 2021 00:24
@danielolsen danielolsen mentioned this pull request Sep 10, 2021
Closed
8 tasks
@danielolsen danielolsen mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielolsen danielolsen danielolsen approved these changes

@BainanXia BainanXia BainanXia approved these changes

@ahurli ahurli ahurli approved these changes

@kasparm kasparm Awaiting requested review from kasparm

Assignees

@rouille rouille

Labels
data intake Use of external data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rouille @danielolsen @BainanXia @ahurli