Formatting and refactoring #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouille
reviewed
Oct 1, 2020
| @@ -1,7 +1,7 @@ | |||
| import os | |||
|
|
|||
| import pandas as pd | |||
| from powersimdata.network.usa_tamu.constants.zones import id2state | |||
| from powersimdata.network.usa_tamu.constants.zones import id2abv | |||
There was a problem hiding this comment.
you can use from powersimdata.network.usa_tamu.constants.zones import abv
rouille
reviewed
Oct 1, 2020
| @@ -47,7 +46,7 @@ def get_pv_tracking_ratio_state(pv_info, state): | |||
| raise TypeError("state must be a list") | |||
|
|
|||
| for s in state: | |||
| if s not in set(id2state.values()): | |||
| if s not in set(id2abv.values()): | |||
There was a problem hiding this comment.
We seem to be switching from state to state abbreviation, is that ok?
There was a problem hiding this comment.
It was always abbreviation. The variable name was poorly chosen
rouille
approved these changes
Oct 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Did some preliminary cleanup that can be reviewed separately from library changes. Fix docstring indentation, powersimdata imports, and refactor how we create the NREL url for downloading data.
What it does
Mostly described above, plus changing to https since I was getting errors when running the notebook. Also updated the setup.py, which adds the solar data file since I needed it for the notebook.
Time to review
5 min - I tested the url refactoring manually, and was using it in my other branch where it works successfully