Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unlicensed dependency and unused code #105

Merged
merged 1 commit into from
Sep 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,17 @@ black = "*"

[packages]
bokeh = "==2.0.2"
h5py = "==2.10.0"
h5pyd = "==0.3.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we no longer need h5py, do we still need h5pyd? We're also pointing to a version that's nearly two years out of date...

Copy link
Collaborator

@rouille rouille Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is used in: prereise/gather/solardata/ga_wind/ga_wind.py. It is needed to retrieve data from a NREL data base.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still using h5pyd in ga_wind.py. Guess it is very stable :) Apparently it's also independent of h5py (looks like it's a rest api client for reading data remotely).

matplotlib = "==3.2.1"
numpy = "==1.18.5"
pandas = "~=1.1.2"
py3samsdk = {editable = true, git = "https://github.com/sjschneider/py3samsdk.git"}
pyproj = "==1.9.6"
pywtk = {editable = true, git = "https://github.com/NREL/pywtk.git"}
pytest = "==5.4.3"
python-dateutil = "==2.7.5"
requests = "==2.21.0"
scipy = "==1.4.1"
tqdm = "==4.29.1"
xlrd = "==1.2.0"
Flask = "==1.1.2"
netCDF4 = "==1.5.3"
Shapely = "==1.7.0"
powersimdata = {editable = true, path = "../PowerSimData"}
99 changes: 1 addition & 98 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 0 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,25 +99,6 @@ tracks with the wind-farm level data shown in NREL's validation report.

Check out the **[rap_demo.ipynb][RAP_notebook]** notebook for demo.

#### ii. Techno-Economic Wind Integration National Dataset Toolkit
The [Techno-Economic WIND (Wind Integration National Dataset) Toolkit][WIND_web]
provides 5-min resolution data for 7 years, ranging from 2007 to 2013, at
120,000 points within the continental U.S. selected for their wind resource.
This set contains power estimates and forecasts along with a subset of
atmospheric variables. Data can be accessed via an [API][WIND_api].

The closest site to the wind farm in the network is found in the NREL dataset
and the associated power estimate is simply scaled to the plant capacity to
obtain a wind power output profile. The procedure is illustrated in the
**[te_wind_demo.ipynb][TE_WIND_notebook]** notebook.

Also, a test can be run as follows:
```python
from prereise.gather.winddata.te_wind.test import te_wind_test

te_wind_test.test()
```


### B. Solar data

Expand Down
2 changes: 1 addition & 1 deletion prereise/gather/winddata/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__all__ = ["rap", "te_wind"]
__all__ = ["rap"]
1 change: 0 additions & 1 deletion prereise/gather/winddata/te_wind/__init__.py

This file was deleted.

Loading