Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ZXing.Net from 0.16.6 to 0.16.7 in /Google.Authenticator.Tests #92

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 27, 2021

Bumps ZXing.Net from 0.16.6 to 0.16.7.

Commits
  • c5eaa15 more updates for deployment scripts and signing
  • 6af7a8a bindings: updated version numbers and dependencies
  • cadfffe update deployment script
  • bcfe909 fixed nuspec file
  • cadfbc7 fixed winmd source code fetching
  • 21c268e updated doc projects
  • 7009491 preparing release 0.16.7
  • 83d6e6a #377 Exception thrown while reading certain QR code
  • 0867d72 updated SkiaSharp test
  • fee1b8a fix bitmap creation for silverlight
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ZXing.Net](https://github.com/micjahn/ZXing.Net) from 0.16.6 to 0.16.7.
- [Release notes](https://github.com/micjahn/ZXing.Net/releases)
- [Commits](micjahn/ZXing.Net@v0.16.6.0...v0.16.7.0)

---
updated-dependencies:
- dependency-name: ZXing.Net
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 27, 2021
@ahwm
Copy link
Collaborator

ahwm commented Dec 27, 2021

@flytzen ZXing.net added a type parameter to their net5.0 version in 0.16.7.

I could change it to BarcodeReaderGeneric and get around that, but then reader.Decode() throws up on net452/net45 as it's expecting a LuminanceSource. As a workaround I moved the instantiation into the #if NETFRAMEWORK conditional block.

Copy link
Collaborator

@flytzen flytzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll teach me to procrastinate on a change so long that that reference version changes 😜

@flytzen flytzen merged commit 9089243 into master Dec 28, 2021
@dependabot dependabot bot deleted the dependabot/nuget/Google.Authenticator.Tests/ZXing.Net-0.16.7 branch December 28, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants