Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated QRCoder dependency to 1.4.2 which added support for .NET 5, u… #72

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

ahwm
Copy link
Collaborator

@ahwm ahwm commented Nov 29, 2021

…pdated TFM for .NET 5 and .NET Core 3.0 -> .NET Core 3.1 on tests project

…pdated TFM for .NET 5 and .NET Core 3.0 -> .NET Core 3.1 on tests project
@ahwm ahwm requested a review from flytzen November 29, 2021 18:12
@ahwm
Copy link
Collaborator Author

ahwm commented Nov 29, 2021

Addresses #71

@ahwm ahwm linked an issue Nov 29, 2021 that may be closed by this pull request
Copy link
Collaborator

@flytzen flytzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think we should bump the major version when we release this?

@flytzen flytzen merged commit b55ff35 into master Nov 30, 2021
@flytzen flytzen deleted the issues/71-qrcoder-update branch November 30, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded dependency to QRCoder 1.4.1?
2 participants