Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of TimeStep #207

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

flytzen
Copy link
Collaborator

@flytzen flytzen commented Mar 13, 2024

  • Added support for specifying the timestep in config
  • Updated version and readme

Fixes #206

@flytzen flytzen requested a review from ahwm March 13, 2024 17:33
@ahwm ahwm merged commit 193478b into master Mar 13, 2024
4 checks passed
@ahwm ahwm deleted the feature/configurablePeriodLength206 branch March 13, 2024 19:48
@asmith3006
Copy link

Thank you! Amazing.

@flytzen
Copy link
Collaborator Author

flytzen commented Mar 14, 2024

@asmith3006 we don't really have a way to test this... We'll publish it as a beta - when we do, can you test it with your devices and let us know if we can release this?
Thanks 😊

@asmith3006
Copy link

Have run this code on a mock console app and tested against a known secret on a physical token and it's working perfectly.

FYI you can also use https://totp.danhersam.com/ to test against a known secret and change the window size for comparison.

Thanks for this! Great work.

@ahwm
Copy link
Collaborator

ahwm commented Mar 14, 2024

That's about as much as we can do with the tests (and is pretty much what the tests check). Let us know once you're able to test it with a real device as well. Glad to hear it's on the right track!

@asmith3006
Copy link

I've compared the output with:

  1. Physical token
  2. Online generator
  3. Powershell script

and all numbers generated by all the systems match perfectly.

I think that's about all the testing I can do, it looks great - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow varying window sizes
3 participants