Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ZXing.Net from 0.16.8 to 0.16.9 in /Google.Authenticator.Tests #140

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2023

Bumps ZXing.Net from 0.16.8 to 0.16.9.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 27, 2023
@ahwm
Copy link
Collaborator

ahwm commented Mar 10, 2023

@flytzen these are failing because of the net5.0 TFM in Google.Authenticator.Tests.csproj and the build agent doesn't have .NET 5 installed (only 3.1, 6.0, and 7.0).

<TargetFrameworks Condition="'$(IsWindows)'=='true'">net462;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(IsLinux)'=='true'">netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks Condition="'$(IsOSX)'=='true'">netcoreapp3.1;net5.0</TargetFrameworks>

Since .NET 5 is technically out of support we probably need to look at changing these. The main project only references netstandard2.0 and net462 - I'm guessing the TFMs specified determine the frameworks it's tested against yes? Updating the tests project should have no bearing on the library version itself right?

@flytzen
Copy link
Collaborator

flytzen commented Mar 10, 2023

Yeah, that's right.
We test from multiple frameworks to make sure everything continues to work.
I'll make a quick PR to remove 5 and add 7.

@ahwm
Copy link
Collaborator

ahwm commented Mar 10, 2023

@dependabot rebase

Bumps [ZXing.Net](https://github.com/micjahn/ZXing.Net) from 0.16.8 to 0.16.9.
- [Release notes](https://github.com/micjahn/ZXing.Net/releases)
- [Commits](micjahn/ZXing.Net@v0.16.8.0...v0.16.9.0)

---
updated-dependencies:
- dependency-name: ZXing.Net
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/Google.Authenticator.Tests/ZXing.Net-0.16.9 branch from 7d7421d to 4cf0173 Compare March 10, 2023 20:55
@ahwm ahwm merged commit de5d140 into master Mar 10, 2023
@ahwm ahwm deleted the dependabot/nuget/Google.Authenticator.Tests/ZXing.Net-0.16.9 branch March 10, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants