Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to use EscapeDataString #120

Merged
merged 1 commit into from
May 26, 2022
Merged

Changed to use EscapeDataString #120

merged 1 commit into from
May 26, 2022

Conversation

flytzen
Copy link
Collaborator

@flytzen flytzen commented May 26, 2022

Fixes #103

I've tested this with three different authenticators and they all handle it correctly:

  • They still display the issuer name correctly
  • It recognises that an account added with the old version is the same if I try to add it again with the new version

@flytzen flytzen mentioned this pull request May 26, 2022
Merged
@flytzen flytzen requested a review from ahwm May 26, 2022 07:38
@ahwm ahwm merged commit b7fd6fa into master May 26, 2022
@ahwm ahwm deleted the feature/EscapeDataString branch May 26, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwm ahwm ahwm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Uri.EscapeUriString
2 participants
@flytzen @ahwm