Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ...else { throw; } ? #85

Closed
flytzen opened this issue Dec 3, 2021 · 1 comment · Fixed by #87
Closed

Missing ...else { throw; } ? #85

flytzen opened this issue Dec 3, 2021 · 1 comment · Fixed by #87

Comments

@flytzen
Copy link
Collaborator

flytzen commented Dec 3, 2021

Looking at the QR generation code because of issue #50 and came across this:

GoogleAuthenticator/Google.Authenticator/TwoFactorAuthenticator.cs

Line 104 in f0f1143

}

shouldn't we have

else { throw; }

in this one and the one below to avoid swallowing exceptions?
@ahwm
Copy link
Collaborator

ahwm commented Dec 7, 2021

That's probably a good idea.

ahwm added a commit that referenced this issue Dec 24, 2021
@ahwm
added throw statements to avoidswallowing errors; addresses #85
09a6ec4
@ahwm ahwm mentioned this issue Dec 24, 2021
Merged
@ahwm ahwm linked a pull request Dec 24, 2021 that will close this issue
added throw statements to avoid swallowing errors #87
Merged
flytzen pushed a commit that referenced this issue Dec 26, 2021
@ahwm
added throw statements to avoidswallowing errors; addresses #85 (#87)
04f5a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added throw statements to avoid swallowing errors BrandonPotter/GoogleAuthenticator
2 participants
@flytzen @ahwm