import typealias correctly for python 3.8+ from typing_extensions Fixes #1448

[hellovai]

Important

Fix TypeAlias import for Python 3.8+ by using typing_extensions in types.py.j2 and types.py.

• Imports:
  • Change TypeAlias import from typing to typing_extensions in types.py.j2 and types.py to support Python 3.8+.

^{This description was created by for d03bb6a. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
baml	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 0:32am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to d03bb6a in 44 seconds

More details

• Looked at 28 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. engine/language_client_codegen/src/python/templates/types.py.j2:5

• Draft comment:
  Correctly switched to importing TypeAlias from typing_extensions for Python 3.8+ compatibility.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative and does not provide any actionable feedback or suggestions. It simply acknowledges a correct change without adding value to the review process.

2. integ-tests/python/baml_client/types.py:19

• Draft comment:
  Correctly updated import to use typing_extensions for TypeAlias to support older Python versions.
• Reason this comment was not posted:
  Marked as duplicate.

3. engine/language_client_codegen/src/python/templates/types.py.j2:5

• Draft comment:
  Good fix: importing TypeAlias from typing_extensions ensures compatibility with Python 3.8/3.9. Confirm that typing_extensions is added as a dependency.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

4. integ-tests/python/baml_client/types.py:19

• Draft comment:
  Importing TypeAlias from typing_extensions correctly here. Ensure dependency on typing_extensions is handled for older runtimes.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50%
  None

Workflow ID: wflow_CSGx3VPix9pGfkwq

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.