Skip to content

Commit

Permalink
ImageBrush shouldn't Dispose of the image it is using.
Browse files Browse the repository at this point in the history
  • Loading branch information
BorisTheBrave committed Apr 13, 2019
1 parent cb18952 commit 58b7e58
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/ImageSharp.Drawing/Processing/ImageBrush{TPixel}.cs
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ public ImageBrushApplicator(ImageFrame<TPixel> target, ImageFrame<TPixel> image,
/// <inheritdoc />
public override void Dispose()
{
this.source.Dispose();
}

/// <inheritdoc />
Expand Down
36 changes: 36 additions & 0 deletions tests/ImageSharp.Tests/Drawing/FillImageBrushTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Copyright (c) Six Labors and contributors.
// Licensed under the Apache License, Version 2.0.

using System;

using SixLabors.ImageSharp.PixelFormats;
using SixLabors.ImageSharp.Primitives;
using SixLabors.ImageSharp.Processing;
using SixLabors.ImageSharp.Tests.TestUtilities.ImageComparison;
using SixLabors.Primitives;
using SixLabors.Shapes;

using Xunit;

// ReSharper disable InconsistentNaming

namespace SixLabors.ImageSharp.Tests.Drawing
{
[GroupOutput("Drawing")]
public class FillImageBrushTests
{
[Fact]
public void DoesNotDisposeImage()
{
using (var src = new Image<Rgba32>(5, 5))
{
var brush = new ImageBrush<Rgba32>(src);
using (var dest = new Image<Rgba32>(10, 10))
{
dest.Mutate(c => c.Fill(brush, new Rectangle(0, 0, 10, 10)));
dest.Mutate(c => c.Fill(brush, new Rectangle(0, 0, 10, 10)));
}
}
}
}
}

0 comments on commit 58b7e58

Please sign in to comment.