Skip to content

Commit

Permalink
Pin golangci-lint to go.mod and regenerate go.sum
Browse files Browse the repository at this point in the history
  • Loading branch information
F21 committed Jan 10, 2019
1 parent 029d451 commit 44263f4
Show file tree
Hide file tree
Showing 5 changed files with 175 additions and 14 deletions.
14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,16 @@ project is structured, it was also almost impossible to add support for embeddab
changes.

## Contributing
We run automatically some sanitizations to check code quality before merging it. For this purpose,
we use the [golangci-lint](https://github.com/golangci/golangci-lint) tool which is run via a [Makefile](Makefile)
target.
We run automatically some linters using [golangci-lint](https://github.com/golangci/golangci-lint) to check code quality
before merging it. This is executed using a [Makefile](Makefile) target.

It is a recommended practice to run and ensure passing all the checks locally before submitting a pull request.
You should run and ensure all the checks pass locally before submitting a pull request. The version of
[golangci-lint](https://github.com/golangci/golangci-lint) to be used is pinned in `go.mod`.

After [installing golangci-lint](https://github.com/golangci/golangci-lint) running a `make sanity-check` locally
would trigger this tests.
To execute the linters:
1. Install `make`.
2. Install [golangci-lint](https://github.com/golangci/golangci-lint) by executing `go install github.com/golangci/golangci-lint/cmd/golangci-lint`.
3. Execute `make sanity-check`.

## License
This library is licensed under the Apache 2 License.
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ require (
github.com/apache/calcite-avatica-go/v3 v3.2.0
github.com/go-sql-driver/mysql v1.4.0
github.com/gobuffalo/packr v1.19.0
github.com/golangci/golangci-lint v1.12.5
github.com/lib/pq v1.0.0
github.com/mattn/go-sqlite3 v1.10.0
google.golang.org/appengine v1.2.0 // indirect
Expand Down
Loading

0 comments on commit 44263f4

Please sign in to comment.