Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExportFormatter: Add missing book description and remove extra newlines in markdown export #5313

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

czemu
Copy link
Contributor

@czemu czemu commented Nov 10, 2024

Hi,

This pull request includes two updates to the app/Entities/Tools/ExportFormatter.php file regarding the markdown export:

  1. Added the missing book description in the bookToMarkdown() method.
  2. Added a check for an empty chapter description, preventing unwanted extra lines (\n\n) between the chapter name and the page content when the description is empty.

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Dec 2, 2024
ssddanbrown added a commit that referenced this pull request Dec 2, 2024
Also updated tests to cover checking description use/conversion.
Made during review of #5313
@ssddanbrown ssddanbrown merged commit f12946d into BookStackApp:development Dec 2, 2024
1 check passed
@ssddanbrown
Copy link
Member

Thanks for these changes/fixes @czemu!
They are now merged to be part of the next feature release.

I followed this up with 0f9957b to handle the wider range of potential formatting in descriptions via HTML to MD conversion, and to also update testing to cover the changes made.

@czemu
Copy link
Contributor Author

czemu commented Dec 2, 2024

Thanks @ssddanbrown!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants